Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Ruff for Python linting #529

Merged
merged 8 commits into from
Mar 4, 2024
Merged

Switch to Ruff for Python linting #529

merged 8 commits into from
Mar 4, 2024

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Oct 27, 2023

Which issue does this PR close?

N/A

Rationale for this change

Ruff seems much simpler and faster than using black, flake8, and isort.

What changes are included in this PR?

  • Add Ruff Github Action
  • Add ci/scripts/python_lint.sh script
  • Update pre-commit script
  • Update README
  • Run ruff to reformat all Python files

Are there any user-facing changes?

@andygrove andygrove requested a review from viirya March 4, 2024 02:56
@andygrove andygrove changed the title Add Ruff CI action Switch to Ruff for Python linting Mar 4, 2024
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

run: |
python -m pip install --upgrade pip
pip install ruff
# Update output format to enable automatic inline annotations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean?

@andygrove andygrove merged commit 76ecf56 into apache:main Mar 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants